THE WEB DEVELOPER COMMIT CHECKLIST

REQUIREMENTS
double check story/feature requirements

double check any comments, messages, etc. about the story

ALL CODE
remove unused code

can logic be done another way (now that you know more about how to implement the feature)

check if variables could be null

don’t set variables unnecessarily (can data be gotten another way)

double check all if/else conditions

know about all places the code is called

access control to pages with URL/form parameters

replace hardcoded code, values and URLs with parameters

JAVA
move code to the lowest level in the domain

use long instead of Long if it can’t be null

use == to compare enums

use .equals to compare Longs

validate all submitted values

CLIENT SIDE
check layout and alignment of UI elements

capitalization

remove unnecessary HTML elements

SQL
did you add all appropriate where clause conditionals

double check order bys

do aggregate functions work correctly with no rows

do you need to add not null to a new column

comments for new tables and columns

add semicolons where appropriate

commit added if necessary?